Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update KyleMayes/install-llvm-action requirement to v1.3.0 #16059

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 10, 2021

Updates the requirements on KyleMayes/install-llvm-action to permit the latest version.

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested review from a team as code owners May 10, 2021 08:47
@dependabot dependabot bot requested a review from nbusseneau May 10, 2021 08:47
@dependabot dependabot bot added kind/enhancement This would improve or streamline existing functionality. release-note/misc This PR makes changes that have no direct user impact. labels May 10, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 10, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 10, 2021
@dependabot dependabot bot requested a review from joestringer May 10, 2021 08:47
@nbusseneau nbusseneau force-pushed the dependabot/github_actions/KyleMayes/install-llvm-action-v1.3.0 branch from 36b8c77 to a57b184 Compare May 10, 2021 10:49
@nbusseneau nbusseneau force-pushed the dependabot/github_actions/KyleMayes/install-llvm-action-v1.3.0 branch from a57b184 to 39ba757 Compare May 10, 2021 10:51
@nbusseneau
Copy link
Member

Manually fixed the original commits because it was doing funny stuff with tags/SHA, I think due to the fact we had a mix of both initially.

@joestringer
Copy link
Member

Thanks @nbusseneau . Do you think it's worth taking the same steps or marking this for backport to handle the other branches (#16060, #16062) or shall we just merge those as-is and settle with using shas going forward on the master branch?

@nbusseneau
Copy link
Member

Thanks @nbusseneau . Do you think it's worth taking the same steps or marking this for backport to handle the other branches (#16060, #16062) or shall we just merge those as-is and settle with using shas going forward on the master branch?

SHAs are technically better, but I wouldn't say it's of utmost importance. Ideally we should just pin all actions anyhow, so perhaps it's better to just merge them as-is and file an issue for pinning everything.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 11, 2021

A newer version of KyleMayes/install-llvm-action exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@joestringer joestringer merged commit 7f4c2e8 into master May 17, 2021
@joestringer joestringer deleted the dependabot/github_actions/KyleMayes/install-llvm-action-v1.3.0 branch May 17, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement This would improve or streamline existing functionality. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants