Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix flake in ValidateEndpointsAreCorrect #16068

Merged

Conversation

pchaigno
Copy link
Member

ValidateEndpointsAreCorrect ensures that all Docker containers have a corresponding Cilium endpoints. The information necessary to match containers with Cilium endpoints is however only available once the endpoints are ready (have received labels, identity, and other information). We therefore need to wait for all endpoints to be ready before running ValidateEndpointsAreCorrect.

Fixes: #14463.

ValidateEndpointsAreCorrect ensures that all Docker containers have a
corresponding Cilium endpoints. The information necessary to match
containers with Cilium endpoints is however only available once the
endpoints are ready (have received labels, identity, and other
information). We therefore need to wait for all endpoints to be ready
before running ValidateEndpointsAreCorrect.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added kind/bug/CI This is a bug in the testing code. area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. ci/flake This is a known failure that occurs in the tree. Please investigate me! labels May 10, 2021
@pchaigno pchaigno requested a review from a team as a code owner May 10, 2021 14:00
@pchaigno pchaigno requested a review from tklauser May 10, 2021 14:00
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.0-rc2 May 10, 2021
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@pchaigno
Copy link
Member Author

test-runtime

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 11, 2021
@jrajahalme jrajahalme merged commit 9fa9672 into cilium:master May 11, 2021
@pchaigno pchaigno deleted the fix-ValidateEndpointsAreCorrect-flake branch May 11, 2021 21:56
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.0-rc2 May 12, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.0-rc2 May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ci/flake This is a known failure that occurs in the tree. Please investigate me! kind/bug/CI This is a bug in the testing code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.10.0-rc2
Backport done to v1.10
Development

Successfully merging this pull request may close these issues.

CI: RuntimeFQDNPolicies Enforces ToFQDNs policy: Docker containers mistmach with Cilium Endpoints
5 participants