Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: bump github.com/vishvananda/netlink to latest master #16070

Merged
merged 1 commit into from
May 11, 2021

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented May 10, 2021

This pulls in vishvananda/netlink#637 and
vishvananda/netlink#648 with data race fixes.

Fixes #15438

Marked for needs-backport/1.10 given that this fixes a data race and go.mod in the v1.10 branch is currently at the same version of github.com/vishvananda/netlink as master.

@tklauser tklauser added the release-note/misc This PR makes changes that have no direct user impact. label May 10, 2021
@tklauser tklauser requested a review from a team as a code owner May 10, 2021 14:39
@tklauser tklauser requested a review from rolinh May 10, 2021 14:39
@tklauser
Copy link
Member Author

test-race-gke

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.0-rc2 May 10, 2021
@tklauser
Copy link
Member Author

test-me-please

@tklauser
Copy link
Member Author

tklauser commented May 10, 2021

This pulls in vishvananda/netlink#637 and
vishvananda/netlink#648 with data race fixes.

Fixes cilium#15438

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser closed this May 10, 2021
@tklauser tklauser deleted the pr/bump-netlink-library branch May 10, 2021 16:58
@tklauser tklauser restored the pr/bump-netlink-library branch May 10, 2021 16:59
@tklauser
Copy link
Member Author

🤦 deleted the branch by accident while trying to push a new version picking up vishvananda/netlink#648

@tklauser tklauser deleted the pr/bump-netlink-library branch May 10, 2021 17:00
@tklauser tklauser restored the pr/bump-netlink-library branch May 10, 2021 17:00
@tklauser tklauser reopened this May 10, 2021
@tklauser
Copy link
Member Author

test-me-please

@tklauser
Copy link
Member Author

test-race-gke

@tklauser
Copy link
Member Author

test-runtime

@tklauser
Copy link
Member Author

test-1.21-4.9

@tklauser
Copy link
Member Author

test-1.20-4.19

@tklauser
Copy link
Member Author

test-1.19-5.4

@tklauser
Copy link
Member Author

tklauser commented May 10, 2021

@tklauser
Copy link
Member Author

All required tests passed, the GKE-Race job failed on an unrelated flake (#16004 https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE-Race-Detection/19/). Marking as ready to merge.

@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 11, 2021
@jrajahalme jrajahalme merged commit f7bd191 into cilium:master May 11, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.0-rc2 May 12, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.0-rc2 May 12, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.0-rc2 May 13, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.0-rc2 May 13, 2021
@tklauser tklauser deleted the pr/bump-netlink-library branch June 14, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0-rc2
Backport done to v1.10
Development

Successfully merging this pull request may close these issues.

[Race Detector] Race between netlink.parseBpfData() and netlink.LinkDeserialize()
6 participants