Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add note about DNS-related policies on OpenShift #16083

Merged
merged 2 commits into from May 12, 2021
Merged

docs: Add note about DNS-related policies on OpenShift #16083

merged 2 commits into from May 12, 2021

Conversation

twpayne
Copy link
Contributor

@twpayne twpayne commented May 11, 2021

No description provided.

@twpayne twpayne added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.10 labels May 11, 2021
@twpayne twpayne requested a review from a team as a code owner May 11, 2021 14:02
@twpayne twpayne requested a review from qmonnet May 11, 2021 14:02
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.0-rc2 May 11, 2021
qmonnet
qmonnet reviewed May 11, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be worth referencing the YAML file from the note in the documentation? Otherwise I'm not sure that 1) users will find it and 2) we'll easily remember what this example was supposed to demonstrate.

@twpayne
docs: Add note about DNS-related policies on OpenShift
a83c34e 
Signed-off-by: Tom Payne <tom@isovalent.com>
@twpayne
docs: Remove unnecessary flags to kubectl exec and trailing whitespace
88bee8b 
Signed-off-by: Tom Payne <tom@isovalent.com>
@twpayne
Copy link
Contributor Author

twpayne commented May 11, 2021

I think it would be worth referencing the YAML file from the note in the documentation?

Agreed. Done with a tabs and a note.

qmonnet
qmonnet approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tab is a good idea. Looks good, thank you!

errordeveloper
errordeveloper approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@errordeveloper errordeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, well spotted!

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 12, 2021
@tklauser tklauser merged commit c3f6ee6 into master May 12, 2021
@tklauser tklauser deleted the pr/twpayne/openshift-dns branch May 12, 2021 15:08
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.0-rc2 May 14, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.0-rc2 May 14, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Needs backport from master in 1.10.0-rc2 May 14, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.0-rc2 May 14, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.0-rc2 May 14, 2021
@aanm aanm mentioned this pull request May 14, 2021
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.0-rc2 May 17, 2021
@aanm aanm mentioned this pull request May 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@errordeveloper errordeveloper errordeveloper approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0-rc2
Backport done to v1.10
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@twpayne @errordeveloper @qmonnet @tklauser @aanm