docs: Add a note about minikube docker driver mode #16086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
backport/1.9
kind/backports
joestringer
reviewed
May 11, 2021
aditighag
commented
May 11, 2021
aditighag
force-pushed
the
pr/aditighag/1.9-minikube-gsg
branch
from
9e3eee5
to
c37639f
Compare
qmonnet
approved these changes
May 12, 2021
brb
requested changes
May 12, 2021
Signed-off-by: Aditi Ghag <aditi@cilium.io>
aditighag
force-pushed
the
pr/aditighag/1.9-minikube-gsg
branch
from
c37639f
to
240e9fa
Compare
joestringer
approved these changes
May 12, 2021
|
@aditighag by the way was there a particular reason to directly target v1.9 branch here? Do we not need a fix for master or is another PR already handling that? |
@joestringer Here is the context - #15769 (comment). I've been meaning to ask this question about documenting minikube related instructions. Why was the guide removed? What's the plan going forward? |
|
@aditighag I think the goal is that all of the basic sandbox environments can just be tested out using https://github.com/cilium/cilium-cli. So no need for dedicated guides any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates: #15769