.github: Test IPsec with high value for keyID #16113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
area/CI
pchaigno
force-pushed
the
pr/pchaigno/test-ipsec-with-high-keyid
branch
2 times, most recently
from
b809919
to
db061df
Compare
2 tasks
pchaigno
added
the
area/encryption
pchaigno
force-pushed
the
pr/pchaigno/test-ipsec-with-high-keyid
branch
5 times, most recently
from
ed9ae6f
to
e73cd17
Compare
We want to use the highest possible value for the key ID in end-to-end tests to be sure to catch packet mark conflicts if any arises. By using the value corresponding to all bits set to 1, any conflict will be caught. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
pr/pchaigno/test-ipsec-with-high-keyid
branch
from
e73cd17
to
8a439e7
Compare
christarazi
approved these changes
Jun 25, 2021
joestringer
approved these changes
Jun 25, 2021
pchaigno
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to use the highest possible value for the key ID in end-to-end tests to be sure to catch packet mark conflicts if any arises. By using the value corresponding to all bits set to 1, any conflict will be caught.
This change was tested with a previous version of this pull request:
The workflows were modified to collect a sysdump even in case of success and those sysdumps are attached here:
keyid-sysdump-gke.zip
keyid-sysdump-eks.zip
keyid-sysdump-aks.zip