Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

daemon: Improve logging of device auto-detection #16118

Merged
merged 2 commits into from Jun 2, 2021
Merged

daemon: Improve logging of device auto-detection #16118

merged 2 commits into from Jun 2, 2021

Conversation

brb
Copy link
Member

@brb brb commented May 12, 2021

See commit msgs.

@brb brb added area/daemon Impacts operation of the Cilium daemon. needs-backport/1.8 labels May 12, 2021
@brb brb requested a review from a team May 12, 2021 13:53
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels May 12, 2021
@brb brb requested a review from jibi May 12, 2021 13:53
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.10 May 12, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.0-rc2 May 12, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.7 May 12, 2021
@brb brb requested a review from pchaigno May 12, 2021 13:53
@brb brb added the release-note/misc This PR makes changes that have no direct user impact. label May 12, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 12, 2021
@joestringer joestringer added this to Needs backport from master in 1.8.11 May 13, 2021
@joestringer joestringer removed this from Needs backport from master in 1.8.10 May 13, 2021
@joestringer joestringer added this to Needs backport from master in 1.9.8 May 13, 2021
@joestringer joestringer removed this from Needs backport from master in 1.9.7 May 13, 2021
@brb
daemon: Remove redundant device derivation for host-fw
2c06c6d 
The devices are being derived by handleNativeDevices() invoked above.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb requested a review from pchaigno May 16, 2021 13:55
@brb brb force-pushed the pr/brb/auto-dev-log-msg branch from 8fa3d22 to f72f24d Compare May 16, 2021 13:55
@brb
daemon: Improve log msg of device auto-detection
f72f24d 
Previously, the msg was misleading by stating that devices were being
derived for the NodePort BPF. It's no longer the case, as the same
devices are used by host-fw and bwm.

Reported-by: Gilberto Bertin <gilberto@isovalent.com>
Reported-by: Paul Chaignon <paul@cilium.io>
Signed-off-by: Martynas Pumputis <m@lambda.lt>
@aanm aanm added this to Needs backport from master in 1.10.0-rc3 May 17, 2021
@aanm aanm removed this from Needs backport from master in 1.10.0-rc2 May 17, 2021
@aanm aanm removed this from Needs backport from master in 1.10.0-rc3 May 19, 2021
@brb
Copy link
Member Author

brb commented May 25, 2021

test-me-please

@aanm aanm added this to Needs backport from master in 1.9.9 May 27, 2021
@aanm aanm removed this from Needs backport from master in 1.9.8 May 27, 2021
@nathanjsweet nathanjsweet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 2, 2021
@nathanjsweet nathanjsweet merged commit 117be40 into master Jun 2, 2021
@nathanjsweet nathanjsweet deleted the pr/brb/auto-dev-log-msg branch June 2, 2021 19:26
@pchaigno pchaigno mentioned this pull request Jun 4, 2021
Merged
@gandro gandro mentioned this pull request Jun 10, 2021
Merged
@aanm aanm moved this from Needs backport from master to Backport done to v1.10 in 1.10.1 Jun 16, 2021
@aanm aanm mentioned this pull request Jun 16, 2021
Merged
@pchaigno pchaigno mentioned this pull request Jun 16, 2021
Merged
@joestringer joestringer moved this from Needs backport from master to Backport done to v1.8 in 1.8.11 Jun 30, 2021
@joestringer joestringer added this to Backport pending to v1.9 in 1.9.10 Jul 19, 2021
@joestringer joestringer removed this from Needs backport from master in 1.9.9 Jul 19, 2021
@joestringer joestringer removed this from Backport pending to v1.9 in 1.9.10 Jul 19, 2021
This was referenced Jul 19, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jibi jibi jibi approved these changes

@pchaigno pchaigno pchaigno approved these changes

Assignees
No one assigned
Labels
area/daemon Impacts operation of the Cilium daemon. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.1
Backport done to v1.10
1.8.11
Backport done to v1.8
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@brb @jibi @pchaigno @gandro @nathanjsweet @joestringer @aanm @aditighag