pkg/aws/eni: new subnet-ids parameter #16119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
mvisonneau
force-pushed
the
eni_subnet_ids
branch
2 times, most recently
from
a0bd785
to
988de67
Compare
ungureanuvladvictor
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
ungureanuvladvictor
added
area/eni
mvisonneau
force-pushed
the
eni_subnet_ids
branch
from
988de67
to
548f74e
Compare
|
test-me-please |
ungureanuvladvictor
requested changes
May 13, 2021
There was a problem hiding this comment.
Overall LGTM but can you update the docs at https://github.com/cilium/cilium/blob/master/Documentation/concepts/networking/ipam/eni.rst#L349 to reflect the new behavior as well?
mvisonneau
force-pushed
the
eni_subnet_ids
branch
from
548f74e
to
c303df9
Compare
|
Oh indeed @ungureanuvladvictor my bad, I updated the docs 👍 |
qmonnet
requested changes
May 13, 2021
This change permits the configuration of specific `SubnetIDs []string`
as part of the pkg/aws/eni/types.ENISpec. Essentially, it follows
the same principle as what was already in place with SecurityGroups /
SecurityGroupTags.
If `SubnetIDs` is set, it will be considered instead of `SubnetTags`. Here
is an example configuration:
```json
{
"cniVersion": "0.3.1",
"name": "cilium",
"type": "cilium-cni",
"enable-debug": false,
"eni": {
"first-interface-index": 0,
"pre-allocate": 10,
"subnet-ids": ["subnet-0661a8d7e35b56e00","subnet-0661a8d7e35b56e01"],
"subnet-tags": {},
"security-group-tags": {},
"security-groups": []
}
}
```
This will result in the operator-aws looking up for subnets matching the
configured list in an exhaustive fashion.
Signed-off-by: Maxime VISONNEAU <maxime.visonneau@gmail.com>
mvisonneau
force-pushed
the
eni_subnet_ids
branch
from
c303df9
to
67340fb
Compare
ungureanuvladvictor
approved these changes
May 13, 2021
|
test-me-please |
tgraf
approved these changes
May 18, 2021
twpayne
approved these changes
May 25, 2021
|
ci-aks |
|
test-1.20-4.19 |
|
test-1.21-4.9 |
|
test-runtime |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change permits the configuration of specific
SubnetIDs []stringas part of the pkg/aws/eni/types.ENISpec. Essentially, it follows
the same principle as what was already in place with SecurityGroups /
SecurityGroupTags.
If
SubnetIDsis set, it will be considered instead ofSubnetTags. Hereis an example configuration:
{ "cniVersion": "0.3.1", "name": "cilium", "type": "cilium-cni", "enable-debug": false, "eni": { "first-interface-index": 0, "pre-allocate": 10, "subnet-ids": ["subnet-0661a8d7e35b56e00","subnet-0661a8d7e35b56e01"], "subnet-tags": {}, "security-group-tags": {}, "security-groups": [] } }This will result in the
operator-awslooking up for subnets matching theconfigured list in an exhaustive fashion.