Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document the policy for backporting documentation changes #16137

Merged
merged 1 commit into from May 28, 2021

Conversation

qmonnet
Copy link
Member

@qmonnet qmonnet commented May 13, 2021

Documentation changes should be backported "as far as they go" on the supported branches, so that users can get relevant information from the documentation branch associated to the software version they run. Document this as part as the criteria for backports.

Context on Slack

Documentation changes should be backported "as far as they go" on the
supported branches, so that users can get relevant information from the
documentation branch associated to the software version they run.
Document this as part as the criteria for backports.

Signed-off-by: Quentin Monnet <quentin@isovalent.com>
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. needs-backport/1.8 sig/contributing Impacts contribution workflow, guidelines, and tools. labels May 13, 2021
@qmonnet qmonnet requested review from a team as code owners May 13, 2021 11:36
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels May 13, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.0-rc2 May 13, 2021
@qmonnet qmonnet added the release-note/misc This PR makes changes that have no direct user impact. label May 13, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 13, 2021
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think this is documenting the reality of the process today.

Will CC in @tgraf for an extra opinion on whether to consider changing the scope of this.

@joestringer joestringer requested a review from tgraf May 13, 2021 16:26
@aanm aanm added this to Needs backport from master in 1.10.0-rc3 May 17, 2021
@aanm aanm removed this from Needs backport from master in 1.10.0-rc2 May 17, 2021
@aanm aanm added this to Needs backport from master in 1.10.1 May 19, 2021
@aanm aanm removed this from Needs backport from master in 1.10.0-rc3 May 19, 2021
@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 27, 2021
@aanm aanm merged commit 2a356d9 into cilium:master May 28, 2021
@qmonnet qmonnet mentioned this pull request Jun 1, 2021
23 tasks
@qmonnet qmonnet mentioned this pull request Jun 2, 2021
6 tasks
@qmonnet qmonnet deleted the pr/doc_backports_policy branch June 4, 2021 08:58
@aanm aanm moved this from Needs backport from master to Backport done to v1.10 in 1.10.1 Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/contributing Impacts contribution workflow, guidelines, and tools.
Projects
No open projects
1.10.1
Backport done to v1.10
Development

Successfully merging this pull request may close these issues.

None yet

6 participants