Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/k8s: ignore overwrite source "custom-resource" with "k8s" errors #16153

Merged
merged 1 commit into from May 17, 2021

Conversation

aanm
Copy link
Member

@aanm aanm commented May 14, 2021

As pointed out in the code changes, it is expected to receive k8s
events after custom-resource events as the propagation delay is often
higher than CRs.

Signed-off-by: André Martins andre@cilium.io

@aanm aanm added release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.10 labels May 14, 2021
@aanm aanm requested review from a team and christarazi May 14, 2021 14:53
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.0-rc2 May 14, 2021
@aanm
Copy link
Member Author

aanm commented May 14, 2021

test-me-please

Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in commit msg. It also says "as pointed out", but no reference to anything

@aanm aanm changed the title pkg/k8s: ignore overwrite source "custom-resource" with "k8s" erros pkg/k8s: ignore overwrite source "custom-resource" with "k8s" errors May 14, 2021
As pointed out in the code changes, it is expected to receive k8s
events after custom-resource events as the propagation delay is often
higher than CRs.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/add-more-expecting-errors branch from edaf1f2 to 5201ef1 Compare May 14, 2021 22:40
@aanm
Copy link
Member Author

aanm commented May 14, 2021

test-me-please

@aanm
Copy link
Member Author

aanm commented May 14, 2021

ci-gke

@aanm aanm added this to Needs backport from master in 1.10.0-rc3 May 17, 2021
@aanm aanm removed this from Needs backport from master in 1.10.0-rc2 May 17, 2021
@aanm aanm merged commit 465cac1 into cilium:master May 17, 2021
@aanm aanm deleted the pr/add-more-expecting-errors branch May 17, 2021 12:35
@aanm aanm moved this from Needs backport from master to Backport done to v1.10 in 1.10.0-rc3 May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0-rc3
Backport done to v1.10
Development

Successfully merging this pull request may close these issues.

None yet

3 participants