Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib: Make upstream commit check more generic #16160

Merged
merged 1 commit into from May 17, 2021

Conversation

joestringer
Copy link
Member

This bash function is super close to being generically useful across
different repositories, by allowing to check whether a commit is in any
particular upstream (including hubble repos). Make it a bit more generic
without changing the default args, that way we don't have to update any
of the existing scripts.

This bash function is super close to being generically useful across
different repositories, by allowing to check whether a commit is in any
particular upstream (including hubble repos). Make it a bit more generic
without changing the default args, that way we don't have to update any
of the existing scripts.

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer requested a review from a team as a code owner May 14, 2021 18:43
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 14, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.0-rc2 May 14, 2021
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label May 14, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 14, 2021
@aanm aanm added this to Needs backport from master in 1.10.0-rc3 May 17, 2021
@aanm aanm removed this from Needs backport from master in 1.10.0-rc2 May 17, 2021
@aanm aanm merged commit 8a2d2d3 into cilium:master May 17, 2021
@joestringer joestringer deleted the submit/find-commit-in-any-remote branch May 18, 2021 00:13
@aanm aanm moved this from Needs backport from master to Backport done to v1.10 in 1.10.0-rc3 May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0-rc3
Backport done to v1.10
Development

Successfully merging this pull request may close these issues.

None yet

7 participants