Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alibabacloud: fix race #16175

Merged
merged 1 commit into from May 19, 2021
Merged

alibabacloud: fix race #16175

merged 1 commit into from May 19, 2021

Conversation

l1b0k
Copy link
Contributor

@l1b0k l1b0k commented May 17, 2021

Fixes: #16170

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 17, 2021
@tklauser tklauser added needs-backport/1.10 release-note/bug This PR fixes an issue in a previous release of Cilium. labels May 17, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 17, 2021
pkg/alibabacloud/eni/node.go Outdated Show resolved Hide resolved
@tklauser
Copy link
Member

@l1b0k could you please rebase your branch and force push again? It looks like Travis CI wasn't triggered by the latest push. Thanks!

@maintainer-s-little-helper
Copy link

Commit 6b1676a2133b72158def230f545a6600657d99a9 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 18, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 18, 2021
@tklauser
Copy link
Member

@l1b0k It looks like now the old change (deleting the read-lock) is back rather than the fix you pushed before in d0f0be8

Signed-off-by: l1b0k <libokang.dev@gmail.com>
@tklauser tklauser closed this May 19, 2021
@tklauser tklauser reopened this May 19, 2021
@tklauser
Copy link
Member

test-me-please

@tklauser
Copy link
Member

tklauser commented May 19, 2021

@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 19, 2021
@tklauser tklauser merged commit 124b81a into cilium:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: potential deadlock in pkg/alibabacloud/eni
4 participants