Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mark node-to-node IPSec encryption as beta #16200

Merged
merged 1 commit into from Jun 7, 2021

Conversation

qmonnet
Copy link
Member

@qmonnet qmonnet commented May 18, 2021

Keep node-to-node encryption in beta mode, to indicate that some issues might remain to be fixed.

(Note: The whole IPsec page was marked as stable/beta for 1.9).

Mark node-to-node encryption explicitly as a beta feature, to indicate
that some issues might remain to be fixed.

Signed-off-by: Quentin Monnet <quentin@isovalent.com>
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.10 labels May 18, 2021
@qmonnet qmonnet requested a review from jrfastab May 18, 2021 10:15
@qmonnet qmonnet requested a review from a team as a code owner May 18, 2021 10:15
@qmonnet qmonnet requested a review from joestringer May 18, 2021 10:15
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks about right to me, did you also get an ack from @jrfastab ? Might be worth pinging him before we merge this.

@jrfastab
Copy link
Contributor

jrfastab commented Jun 4, 2021

I'm OK with this, but would consider adding workflows for node to node case and then flipping it out of beta. But, without workflows for us to verify its working in all our supported environments its easy to have a regression in one of the corner cases. So, marking BETA makes some sense until this happens.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 4, 2021
@aanm aanm merged commit 7eb7bc6 into cilium:master Jun 7, 2021
@qmonnet qmonnet deleted the pr/n2n-enc-beta branch June 9, 2021 09:26
@pchaigno
Copy link
Member

pchaigno commented Apr 6, 2022

(Note: The whole IPsec page was marked as stable/beta for 1.9).

Let's backport anyway because otherwise in v1.9 it's not super clear that node-to-node encryption is beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants