pkg/redirectpolicy: Make code robust against incorrect policy configu… #16216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
aditighag
added
the
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
@aditighag hey, what's the status of this PR? I've been waiting for it to be marked ready for review before having a look. |
|
test-only --focus="K8sServicesTest.* LRP" --kernel_version="net-next" |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
stale
aditighag
force-pushed
the
pr/aditighag/lrp-fix-incorrect-config
branch
from
4cbaf5f
to
70d510a
Compare
|
test-only --focus="K8sLRPTests" --kernel_version="net-next" Rebased the PR. |
|
Focused tests relevant to the code changes (LRP tests) have passed. |
christarazi
requested changes
Jul 21, 2021
joamaki
removed
the
ready-to-merge
|
Reviews are in and focused LRP tests have passed - https://jenkins.cilium.io/job/Cilium-PR-Tests-Kernel-Focus/293/. Based on the out-of-band comment from Jussi, I've added a comment in the commit description and the code. No need to re-run the test. Edit : checkpath warning can be ignored -
|
…rations If an incorrect service name is specified in an LRP, we need to guard against this case when service IP can't be retrieved. Also, when a valid LRP is applied before the service it selects, service information won't be available in the manager callback to add an LRP. The LRP will be applied when the service callback is later received by the manager. Signed-off-by: Aditi Ghag <aditi@cilium.io>
aditighag
force-pushed
the
pr/aditighag/lrp-fix-incorrect-config
branch
from
43ee72c
to
ce0d7af
Compare
aditighag
added
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.10
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Needs backport from master
in 1.9.10
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.10
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.4
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.4
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.10
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.10
This was referenced Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message.
Fixes: #16204
Release note