Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix Helm instructions for BGP #16263

Merged
merged 1 commit into from May 25, 2021
Merged

docs: Fix Helm instructions for BGP #16263

merged 1 commit into from May 25, 2021

Conversation

xentobias
Copy link
Contributor

@xentobias xentobias commented May 21, 2021 •
edited

Helm value "bgp.announce.lbIP" is invalid, it should be "bgp.announce.loadbalancerIP".
(Source: https://github.com/cilium/cilium/tree/v1.10.0/install/kubernetes/cilium#values)

Signed-off-by: Tobias Mose tobias.mose@xentom.com

@xentobias xentobias requested a review from a team as a code owner May 21, 2021 13:52
@xentobias xentobias requested a review from qmonnet May 21, 2021 13:52
@maintainer-s-little-helper
Copy link

Commit 0c34921dacd0a2600080c07a8298f180f7ae75f7 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels May 21, 2021
@tklauser tklauser added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels May 21, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 21, 2021
@qmonnet qmonnet requested a review from christarazi May 21, 2021 13:58
qmonnet
qmonnet approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
(Please make sure to sign-off your commit as explained at the link above.)

christarazi
christarazi requested changes May 21, 2021
View reviewed changes
Copy link
Member

@christarazi christarazi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please state what the commit is changing. So a commit title such as "docs: Fix Helm instructions for BGP" can work and please make sure the commit is signed off as Quentin mentioned

@xentobias xentobias changed the title Invalid helm value in the documentation (bgp) docs: Fix Helm instructions for BGP May 21, 2021
@xentobias xentobias changed the title docs: Fix Helm instructions for BGP Invalid helm value in the documentation (bgp) May 21, 2021
@xentobias xentobias changed the title Invalid helm value in the documentation (bgp) docs: Fix Helm instructions for BGP May 21, 2021
@maintainer-s-little-helper
Copy link

Commits 0c34921dacd0a2600080c07a8298f180f7ae75f7, d3b8f1bd992af5011574c12b81a377eb3cfb987a do not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 21, 2021
@christarazi
Copy link
Member

The sign off I think needs to have the email within angle brackets, <address@email.com>

@xentobias
docs: Fix Helm instructions for BGP
fbcc05f 
Signed-off-by: Tobias Mose <tobias.mose@xentom.com>
christarazi
christarazi approved these changes May 22, 2021
View reviewed changes
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 24, 2021
@twpayne twpayne merged commit 6c0604e into cilium:master May 25, 2021
@xentobias xentobias deleted the patch-1 branch May 25, 2021 12:40
@qmonnet qmonnet mentioned this pull request May 26, 2021
Closed
@qmonnet qmonnet mentioned this pull request Jun 1, 2021
Merged
23 tasks
@aanm aanm mentioned this pull request Jun 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christarazi christarazi christarazi approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@xentobias @christarazi @qmonnet @twpayne @tklauser @aanm