Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/k8s: ignore namespace events that do not change labels #16268

Merged
merged 1 commit into from
May 26, 2021

Conversation

aanm
Copy link
Member

@aanm aanm commented May 21, 2021

As we can receive different type of namespace events, like difference in
the annotations. We can ignore all of these events unless the labels are
different.

Signed-off-by: André Martins andre@cilium.io

Ignore K8s namespace events that have the same labels

As we can receive different type of namespace events, like difference in
the annotations. We can ignore all of these events unless the labels are
different.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added release-note/bug This PR fixes an issue in a previous release of Cilium. needs-backport/1.8 labels May 21, 2021
@aanm aanm requested a review from a team May 21, 2021 17:22
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.8 May 21, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.11 May 21, 2021
@aanm aanm requested a review from brb May 21, 2021 17:22
@aanm
Copy link
Member Author

aanm commented May 21, 2021

test-me-please

@aanm
Copy link
Member Author

aanm commented May 26, 2021

hit #16122 and #16237

@aanm aanm merged commit 83391b4 into cilium:master May 26, 2021
@aanm aanm deleted the pr/ignore-same-ns-label-changes branch May 26, 2021 00:18
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.8 May 27, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.8 May 27, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.8 May 27, 2021
@qmonnet qmonnet mentioned this pull request Jun 1, 2021
23 tasks
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.11 Jun 10, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.11 Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
No open projects
1.8.11
Backport done to v1.8
1.9.8
Backport done to v1.9
Development

Successfully merging this pull request may close these issues.

None yet

7 participants