endpoint: Skip waiting-to-regenerate -> waiting-for-identity state transitions #16271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrajahalme
added
kind/bug
jrajahalme
force-pushed
the
endpoint-fix-state-transition
branch
from
75d612d
to
cee6c1d
Compare
|
test-me-please |
jrajahalme
force-pushed
the
endpoint-fix-state-transition
branch
from
cee6c1d
to
f5b3b15
Compare
|
test-me-please |
|
test-1.21-4.9 hit by known flake #14959 |
|
test-1.21-4.9 |
Regeneration logic fails if waiting-for-identity changes to ready state in a scenario like this: builder: ready -> waiting-to-regenerate .. label change etc: waiting-to-regenerate -> waiting-for-identity .. labels resolved: waiting-for-identity -> ready .. builder: (ready) -> regenerating (FAILS as this is not expected) Resolve this by giving precedence to the waiting-to-regenerate state over the waiting-for-identity state. Compensate for possibly blocking this state change in Cilium endpoint PATCH API. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
force-pushed
the
endpoint-fix-state-transition
branch
from
f5b3b15
to
82d21d1
Compare
|
test-me-please |
|
test-1.21-4.9 hit by known flake #14959 |
|
test-1.21-4.9 |
|
test-1.16-netnext hit by known flake #13853 |
|
test-1.16-netnext |
aanm
approved these changes
May 25, 2021
jrajahalme
added
the
ready-to-merge
|
ci-aks |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.8
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.8
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.8
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.11
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.11
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Needs backport from master
in 1.8.11
|
The backport labels weren't correctly set after the backport commits were re-added - #16497 (comment). Updating the labels manually. |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport done to v1.8
in 1.8.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regeneration logic fails if waiting-for-identity changes to ready state in a scenario like this:
builder: ready -> waiting-to-regenerate
..
label change etc: waiting-to-regenerate -> waiting-for-identity
..
labels resolved: waiting-for-identity -> ready
..
builder: (ready) -> regenerating (FAILS as this is not expected)
Resolve this by giving precedence to the waiting-to-regenerate state
over the waiting-for-identity state. Compensate for possibly blocking
this state change in Cilium endpoint PATCH API.
Signed-off-by: Jarno Rajahalme jarno@isovalent.com