.github: Fix scheduled end-to-end tests #16274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 50df544 added a new job in the end-to-end workflows to checkout the tested code and run paths-filter on it. That first job fails when the workflows are scheduled (vs. triggered by PR comment) because we try to grab the pull request URL, which doesn't exist: curl ${{ github.event.issue.pull_request.url }} > pr.json results in error: Run curl > pr.json curl: try 'curl --help' or 'curl --manual' for more information We can avoid this by skipping steps in the first job when triggered by schedule. We can't skip the entire first job because the second job has a dependency on the first and would fail if we skipped the first. Fixes: 50df544 (".github: Skip unnecessary ci-xxx tests") Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
kind/bug/CI
aanm
approved these changes
May 21, 2021
nbusseneau
approved these changes
May 21, 2021
pchaigno
added
the
ready-to-merge
|
Removing the label for backport, the relevant parts of the GitHub actions are not in 1.10. |
They should be added then. There's probably a PR missing its backport label somewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 50df544 added a new job in the end-to-end workflows to checkout the tested code and run paths-filter on it. That first job fails when the workflows are scheduled (vs. triggered by PR comment) because we try to grab the pull request URL, which doesn't exist:
results in error:
We can avoid this by skipping steps in the first job when triggered by schedule. We can't skip the entire first job because the second job has a dependency on the first and would fail if we skipped the first.
Fix tested at https://github.com/pchaigno/cilium/actions/runs/865244530 by pushing to the default branch of my fork.
Fixes: #16157.