Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove 1.7 upgrade guide and add upgradeCompatibility for 1.9 #16288

Merged
merged 1 commit into from May 26, 2021

Conversation

aanm
Copy link
Member

@aanm aanm commented May 25, 2021

Signed-off-by: André Martins andre@cilium.io

@aanm aanm added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.10 labels May 25, 2021
@aanm aanm requested a review from a team as a code owner May 25, 2021 01:22
@aanm aanm requested a review from qmonnet May 25, 2021 01:22
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can you please check if the table in section https://docs.cilium.io/en/latest/operations/upgrade/#version-specific-notes should be updated too?

@qmonnet
Copy link
Member

qmonnet commented May 25, 2021

The GitHub action complains about a leftover reference to the removed label, file Documentation/gettingstarted/kubeproxy-free.rst has:

For existing Cilium deployments in version v1.6 or prior, please consult the :ref:`1.7_upgrade_notes`.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm requested a review from qmonnet May 26, 2021 00:14
@aanm aanm requested a review from a team May 26, 2021 00:14
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

| ``1.7.0`` | ``1.7.1`` | Minimal to None | Clients must reconnect[1] |
+-----------------------+-----------------------+-------------------------+---------------------------+
| ``>=1.7.1`` | ``1.7.y`` | Minimal to None | Clients must reconnect[1] |
+-----------------------+-----------------------+-------------------------+---------------------------+
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you checked that no entry is necessary in this table for migrating from 1.9.x to 1.10.y.

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 26, 2021
@twpayne twpayne merged commit 076f475 into cilium:master May 26, 2021
@qmonnet qmonnet mentioned this pull request Jun 1, 2021
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants