Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxylib/test: fix data race between StartAccessLogServer and Close #16298

Merged
merged 1 commit into from May 28, 2021

Conversation

tklauser
Copy link
Member

Don't attempt to accept the connection if the server is closing.

Fixes #16296

Don't attempt to accept the connection if the server is closing.

Fixes cilium#16296

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser added release-note/misc This PR makes changes that have no direct user impact. ci/flake This is a known failure that occurs in the tree. Please investigate me! labels May 25, 2021
@tklauser tklauser requested a review from jrajahalme May 25, 2021 10:54
@tklauser tklauser requested a review from a team as a code owner May 25, 2021 10:54
@aanm aanm merged commit 47d4224 into cilium:master May 28, 2021
@tklauser tklauser deleted the pr/proyxlib-fix-testmemcache-race branch May 31, 2021 08:31
@tklauser
Copy link
Member Author

Marked as needs-backport/1.10 to resolve merge conflict in backport of #17141.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/flake This is a known failure that occurs in the tree. Please investigate me! release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Race Detector] Race in proxylib between (*AccessLogServer).Close() and test.StartAccessLogServer
3 participants