Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install: Allow setting enable-health-check-nodeport to 'false' #16323

Merged
merged 1 commit into from Jun 2, 2021
Merged

install: Allow setting enable-health-check-nodeport to 'false' #16323

merged 1 commit into from Jun 2, 2021

Conversation

dctrwatson
Copy link
Contributor

Per https://docs.cilium.io/en/v1.10/gettingstarted/kubeproxy-free/#kube-proxy-hybrid-modes , when kubeProxyReplacement=partial, enableHealthCheckNodeport should be false. However, the current helm template only allows using the default of true or explicitly settings to true.

@dctrwatson
install: Allow setting enable-health-check-nodeport to 'false'
8cd6749 
Signed-off-by: John Watson <johnw@planetscale.com>
@dctrwatson dctrwatson requested a review from a team as a code owner May 26, 2021 23:24
@dctrwatson dctrwatson requested review from a team, kaworu and nathanjsweet May 26, 2021 23:24
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 26, 2021
@gandro gandro added area/helm Impacts helm charts and user deployment experience needs-backport/1.9 release-note/bug This PR fixes an issue in a previous release of Cilium. labels May 27, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 27, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.8 May 27, 2021
gandro
gandro approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks, I also marked this for backport.

@aanm aanm added this to Needs backport from master in 1.9.9 May 27, 2021
@aanm aanm removed this from Needs backport from master in 1.9.8 May 27, 2021
nathanjsweet
nathanjsweet approved these changes Jun 2, 2021
View reviewed changes
Copy link
Member

@nathanjsweet nathanjsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nathanjsweet nathanjsweet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 2, 2021
@nathanjsweet nathanjsweet merged commit b69258b into cilium:master Jun 2, 2021
@pchaigno pchaigno mentioned this pull request Jun 4, 2021
Merged
@aanm aanm mentioned this pull request Jun 16, 2021
Merged
@pchaigno pchaigno mentioned this pull request Jun 16, 2021
Merged
@joestringer joestringer added this to Backport pending to v1.9 in 1.9.10 Jul 19, 2021
@joestringer joestringer removed this from Needs backport from master in 1.9.9 Jul 19, 2021
@joestringer joestringer removed this from Backport pending to v1.9 in 1.9.10 Jul 19, 2021
@joestringer joestringer mentioned this pull request Jul 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@kaworu kaworu kaworu approved these changes

@nathanjsweet nathanjsweet nathanjsweet approved these changes

Assignees
No one assigned
Labels
area/helm Impacts helm charts and user deployment experience ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dctrwatson @gandro @kaworu @nathanjsweet @joestringer @pchaigno @aanm