Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix a typo in Helm installation documentation #16325

Merged
merged 1 commit into from
May 28, 2021
Merged

docs: fix a typo in Helm installation documentation #16325

merged 1 commit into from
May 28, 2021

Conversation

netflash
Copy link
Contributor

@netflash netflash commented May 27, 2021 •
edited
Loading

Please ensure your pull request adheres to the following guidelines:

  • For first-time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well-written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Fixes: documentation typo

@netflash netflash requested a review from a team as a code owner May 27, 2021 03:17
@netflash netflash requested a review from qmonnet May 27, 2021 03:17
@maintainer-s-little-helper
Copy link

Commit 29b7260ae36a45e3391eb3ca5dc95cbbd2fbad74 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels May 27, 2021
@netflash
typo
28a38d8 
Signed-off-by: Alex Romanov <alex@romanov.ws>
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 27, 2021
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. needs-backport/1.10 release-note/misc This PR makes changes that have no direct user impact. labels May 27, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels May 27, 2021
@qmonnet qmonnet changed the title typo docs: fix a typo in Helm installation documentation May 27, 2021
qmonnet
qmonnet approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I'm not sure how this slipped through the spell checks 🤔

Thanks a lot for the fix!

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 27, 2021
@maintainer-s-little-helper
Copy link

Commit 1f71509acbb89b79b3cea61805c53869c1f67b1a does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 27, 2021
@maintainer-s-little-helper
Copy link

Commit 1f71509acbb89b79b3cea61805c53869c1f67b1a does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@netflash
Copy link
Contributor Author

@qmonnet no dramas,
Looks like I screwed this PR over by trying to merge upstream:master into my merge.

Can you please just fix this yourself and close this PR?
I'm not a developer and I doubt I am ever gonna go beyond fixing typos.

@aanm aanm merged commit a0e3269 into cilium:master May 28, 2021
@aanm
Copy link
Member

aanm commented May 28, 2021

@netflash all good. Thanks!

@qmonnet qmonnet mentioned this pull request Jun 1, 2021
Merged
23 tasks
@aanm aanm mentioned this pull request Jun 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@netflash @aanm @qmonnet