Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cilium_egress_v4 to ignoredELFPrefixes #16334

Merged
merged 1 commit into from Jun 9, 2021
Merged

Add cilium_egress_v4 to ignoredELFPrefixes #16334

merged 1 commit into from Jun 9, 2021

Conversation

Divya063
Copy link
Contributor

Fixes: #16277
Signed-off-by: Divya Rani ranidivya063@gmail.com

@Divya063 Divya063 requested a review from a team as a code owner May 27, 2021 12:38
@Divya063 Divya063 requested a review from ti-mo May 27, 2021 12:38
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 27, 2021
@ti-mo
Copy link
Contributor

ti-mo commented Jun 1, 2021

Hi @Divya063, thanks for the patch. Could you add a short description of the change to the commit message? A GH issue link is not very useful.

@pchaigno #16277 doesn't contain much context. Does this cause any impact, or is it really just a warning?

@ti-mo ti-mo added kind/cleanup This includes no functional changes. sig/loader Impacts the loading of BPF programs into the kernel. release-note/misc This PR makes changes that have no direct user impact. labels Jun 1, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 1, 2021
@pchaigno
Copy link
Member

pchaigno commented Jun 1, 2021

@pchaigno #16277 doesn't contain much context. Does this cause any impact, or is it really just a warning?

It only causes a warning.

@ti-mo
Copy link
Contributor

ti-mo commented Jun 4, 2021

@Divya063 This should be good to go with a slightly more detailed commit message.

@Divya063
Add cilium_egress_v4 to ignoredELFPrefixes
cee3208 
cilium_egress_v4 map was not added in the list of symbols to skip in the
ELF, resulting in the following warning:

    level=warning msg="Skipping symbol substitution" subsys=elf symbol=cilium_egress_v4

Fixes: cilium#16277
Signed-off-by: Divya Rani <ranidivya063@gmail.com>
ti-mo
ti-mo approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@ti-mo ti-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ti-mo ti-mo added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 9, 2021
@aanm aanm merged commit 29ab843 into cilium:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti-mo ti-mo ti-mo approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/loader Impacts the loading of BPF programs into the kernel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skipping symbol substitution cilium_egress_v4
4 participants
@Divya063 @ti-mo @pchaigno @aanm