Minikube guide updates

[aditighag]

Add a note about --cni=cilium flag that can automatically install Cilium. However, it installs v1.8 by default so add a note regarding this.

Cilium init script mounts the BPF fs if not already mounted so the manual step to mount BPF fs isn't required. Let's double check -

$ minikube start --network-plugin=cni
$ cilium install
$ minikube ssh -- mount | grep bpf
none on /sys/fs/bpf type bpf (rw,relatime)

ks logs cilium-zp2st -c ebpf-mount
Mounting eBPF filesystem...

ebpf-mount is the init container that mounts the BPF fs. Here is the relevant code in cilium/cli - https://github.com/cilium/cilium-cli/blob/master/install/install.go#L685

Fixes: #16324

[maintainer-s-little-helper]

Commit 7a3445db6e92da4ceec28c0e3523c351968878c8 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

[maintainer-s-little-helper]

Commit 12f089d757c683d701f730c4e568653ca09a440f does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

[qmonnet]

Cilium init script mounts the BPF fs if not already mounted so the manual step to mount BPF fs isn't required.

(Note that it could be worth having the above in the commit log of the revert patch. Not blocking, though.)

Looks good, thank you! Don't forget to sign-off :)

[aditighag]

@qmonnet Updated the commit description for the reverted commit. Thanks!

[joestringer]

👍

I'm ambivalent about documenting the minikube --cni=cilium ... flag or not, seems like we have legitimate reasons not to recommend the user to use it so it'd be simpler to omit the instruction. That said it's not a big deal to also just let the user know like this. However I think if we do so, we should move the note inside the group tab for minikube users rather than instruct all users about this, even if they've clicked one of the other group tabs (why would cloud or kind users need to be told about a minikube feature?).