.github: Fix error triggered by large comments #16360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure random pull request comments don't cancel ongoing workflows, commit c569ead (".github: Fix concurrency group for comment-triggered workflows") appended the comment message to the concurrency group name. Unfortunately, that results in an error when the comment is too large: The maximum allowed memory size was exceeded while evaluating the following expression This commit fixes that error by simply appending 'trigger-phrase' if the comment is one of the allowed trigger phrases and appending nothing otherwise. That way we avoid appending the whole comment to the concurrency group name, but still get a different concurrency group name for random comments and trigger comments. Fixes: c569ead (".github: Fix concurrency group for comment-triggered workflows") Reported-by: Nicolas Busseneau <nicolas@isovalent.com> Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
kind/bug/CI
aanm
approved these changes
May 28, 2021
nbusseneau
approved these changes
May 28, 2021
pchaigno
added
the
ready-to-merge
|
I had forgotten the backport label here. I'll make it in the next batch of backports, which I think is fine given it's not a critical error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure random pull request comments don't cancel ongoing workflows, commit c569ead (".github: Fix concurrency group for comment-triggered workflows") appended the comment message to the concurrency group name. Unfortunately, that results in an error when the comment is too large:
This pull request fixes that error by simply appending
trigger-phraseif the comment is one of the allowed trigger phrases and appending nothing otherwise. That way we avoid appending the whole comment to the concurrency group name, but still get a different concurrency group name for random comments and trigger comments.This change was tested on a toy repository with both trigger phrases and a large comment.
Fixes: #16310.