Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator: remove deprecated options #16374

Merged
merged 2 commits into from Jun 2, 2021
Merged

operator: remove deprecated options #16374

merged 2 commits into from Jun 2, 2021

Conversation

twpayne
Copy link
Contributor

@twpayne twpayne commented May 31, 2021

Drive-by cleanup: these were scheduled to be removed in 1.10 or earlier.

Remove deprecated --update-ec2-apdater-limit-via-api option

@twpayne twpayne added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. area/operator Impacts the cilium-operator component labels May 31, 2021
@twpayne twpayne requested a review from a team as a code owner May 31, 2021 12:35
@twpayne
operator: remove deprecated --update-ec2-apdater-limit-via-api option
cf24297 
Signed-off-by: Tom Payne <tom@isovalent.com>
@twpayne
operator: remove unused variable
9277044 
Signed-off-by: Tom Payne <tom@isovalent.com>
@twpayne twpayne requested a review from a team as a code owner May 31, 2021 12:36
@twpayne twpayne requested a review from a team May 31, 2021 12:36
@twpayne
Copy link
Contributor Author

twpayne commented May 31, 2021

test-me-please

@twpayne
Copy link
Contributor Author

twpayne commented May 31, 2021

test-1.16-netnext failure is flake #15572.

test-runtime failure seems to be a new flake, #16377.

@twpayne
Copy link
Contributor Author

twpayne commented May 31, 2021

test-1.16-netnext

@twpayne
Copy link
Contributor Author

twpayne commented May 31, 2021

test-runtime

ungureanuvladvictor
ungureanuvladvictor approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@ungureanuvladvictor ungureanuvladvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the ENI changes.

@twpayne
Copy link
Contributor Author

twpayne commented Jun 2, 2021

The ci-aks failure is almost certainly a flake, so marking this as ready-to-merge.

@twpayne twpayne added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 2, 2021
@nathanjsweet nathanjsweet merged commit ab6d9ed into cilium:master Jun 2, 2021
@twpayne twpayne deleted the pr/twpayne/remove-deprecated-flags branch June 3, 2021 12:32
@pchaigno pchaigno mentioned this pull request Jun 4, 2021
Merged
@aanm aanm mentioned this pull request Jun 16, 2021
Merged
@jrajahalme jrajahalme mentioned this pull request Jul 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@errordeveloper errordeveloper errordeveloper approved these changes

@ungureanuvladvictor ungureanuvladvictor ungureanuvladvictor approved these changes

Assignees
No one assigned
Labels
area/operator Impacts the cilium-operator component ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@twpayne @errordeveloper @ungureanuvladvictor @nathanjsweet @pchaigno @aanm