endpoint: trigger k8s sync controller on identity update #16381
Conversation
jibi
added
sig/k8s
pkg/controller/manager.go
Outdated
| @@ -135,7 +136,7 @@ func (m *Manager) removeController(ctrl *Controller) { | |||
| ctrl.getLogger().Debug("Removed controller") | |||
| } | |||
|
|
|||
| func (m *Manager) lookup(name string) *Controller { | |||
| func (m *Manager) Lookup(name string) *Controller { | |||
There was a problem hiding this comment.
No action required, just a thought:
One thing that I just noticed is that this export here is the first export that gives access to a Controller struct outside of the package. All other methods of the Manager do not allow direct access to the Controller. While it seems safe (i.e. it seems that m.mutex is not protecting it), I wonder if it might be cleaner and more future-proof to expose a TriggerController(name string) method instead (similar to TerminationChannel), instead of allowing a a direct lookup.
There was a problem hiding this comment.
Yeah, makes sense, that's where (e *Endpoint) TriggerController(name string) should actually live 👍
Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
jibi
force-pushed
the
pr/jibi/ipcache-propagation-delay
branch
from
a3e881a
to
26d3fca
Compare
|
test-me-please |
|
@jibi can you add the GH issue ID this fixes? |
When an endpoint's identity is updated, Cilium does not sync immediately the new state with k8s, but rather waits up to 10 seconds for the sync-to-k8s-ciliumendpoint controller to run, meaning that the the new identity can remain unannounced for up to 10 seconds. This commit fixes this by explicitly triggering the k8s sync controller whenever an endpoint's identity is updated. Fixes: #15097 Suggested-by: Sebastian Wicki <sebastian@isovalent.com> Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
jibi
force-pushed
the
pr/jibi/ipcache-propagation-delay
branch
from
26d3fca
to
35b2ed8
Compare
My bad, I thought GH would look for that also in commit messages 🤦♂️ |
|
test-me-please |
|
retest-5.4 |
|
Added for backporting to 1.10, otherwise we'll continue having these flakes in 1.10 automated jobs ad vitam æternam. |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.9
When an endpoint's identity is updated, Cilium does not sync immediately
the new state with k8s, but rather waits up to 10 seconds for the
sync-to-k8s-ciliumendpoint controller to run, meaning that the the new
identity can remain unannounced for up to 10 seconds.
This commit fixes this by explicitly triggering the k8s sync controller
whenever an endpoint's identity is updated.
Fixes #15097