.github: Limit CodeQL workflow to .go files #16389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
area/CI-improvement
pchaigno
commented
Jun 1, 2021
|
I filled #16392 for the ConformanceKind1.19 failure. |
twpayne
approved these changes
Jun 2, 2021
pchaigno
force-pushed
the
limit-go-github-workflows
branch
from
3fe8c4d
to
69c4db4
Compare
aanm
reviewed
Jun 2, 2021
CodeQL seems to require that we run the static analysis on the same
branches for push and pull_request triggers. If we don't, it complains
with:
Please make sure that every branch in on.pull_request is also in
on.push so that Code Scanning can compare pull requests against
the state of the base branch.
This commit changes the workflow to run on all stable branches for both
triggers. That will increase the number of times we run that job, but
subsequent commits will restrict that.
Signed-off-by: Paul Chaignon <paul@cilium.io>
This commit changes the CodeQL workflow to only run when the code touches .go files. That should reduce the number of times we run this ~20min-long workflow. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
limit-go-github-workflows
branch
from
69c4db4
to
a63c0ba
Compare
aanm
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.
This pull request could be extended to
lint-go.yamlbut I'm not sure it's worth it currently, given that test is very fast.