Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitor: print error message on failure to decode layer #16397

Merged
merged 1 commit into from Jun 3, 2021

Conversation

qmonnet
Copy link
Member

@qmonnet qmonnet commented Jun 2, 2021

Print an error message as part of the monitor verbose output when the packet parser fails to decode a layer properly. This allows to better understand how some packets are formed. For example, it provides more information for UDP fragments that do not have a UDP header.

Print an error message as part of the monitor verbose output when the
packet parser fails to decode a layer properly. This allows to better
understand how some packets are formed. For example, it provides more
information for UDP fragments that do not have a UDP header.

Signed-off-by: Quentin Monnet <quentin@isovalent.com>
@qmonnet qmonnet added area/monitor Impacts monitoring, access logging, flow logging, visibility of datapath traffic. release-note/misc This PR makes changes that have no direct user impact. labels Jun 2, 2021
@qmonnet qmonnet requested review from a team and kkourt June 2, 2021 14:50
@qmonnet
Copy link
Member Author

qmonnet commented Jun 2, 2021

test-me-please

pkg/monitor/dissect.go Show resolved Hide resolved
@nathanjsweet nathanjsweet merged commit ab6f67e into cilium:master Jun 3, 2021
@qmonnet qmonnet deleted the pr/monitor_dissector_err branch June 3, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitor Impacts monitoring, access logging, flow logging, visibility of datapath traffic. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants