test: Wait for kube-dns before starting test #16411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrajahalme
added
the
area/CI-improvement
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
test-1.21-4.9 |
anfernee
reviewed
Jun 3, 2021
test/k8sT/fqdn.go
Outdated
| @@ -85,6 +85,11 @@ var _ = SkipDescribeIf(helpers.RunsOn54Kernel, "K8sFQDNTest", func() { | |||
| err = kubectl.WaitforPods(helpers.DefaultNamespace, "-l zgroup=testapp", helpers.HelperTimeout) | |||
| Expect(err).Should(BeNil(), "Testapp is not ready after timeout") | |||
|
|
|||
| // Validate that coredns is reachable from test pods | |||
| err = kubectl.NslookupInPod(helpers.DefaultNamespace, appPods[helpers.App2], | |||
| fmt.Sprintf("kube-dns.%s.svc.cluster.local", helpers.CiliumNamespace)) | |||
There was a problem hiding this comment.
I believe kube-dns always runs in kube-system, is it not true?
There was a problem hiding this comment.
You must be right, will fix :-)
Wait for kube-dns to become reachable before running test in fqdn.go. Fixes: cilium#16409 Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
force-pushed
the
pr/jrajahalme/test-isolate-coredns-flakes
branch
from
81aff2f
to
82ec0b9
Compare
|
test-me-please |
nebril
approved these changes
Jun 4, 2021
|
test-1.20-4.19 had timed out |
|
test-1.20-4.19 |
|
test-1.20-4.19 |
|
test-1.20-4.19 |
|
The two CI flakes are unrelated to this change, flagging as ready-to-merge. |
jrajahalme
added
the
ready-to-merge
|
Should we be backporting this to v1.10 to help stabilize CI? |
|
@joestringer Yeah, I was just going to comment the same based on the comment I posted in #16671. You beat me to it. :) /cc @jrajahalme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for kube-dns to become reachable from test pod before running test in fqdn.go.
Fixes: #16409