test: Specify node-selectors in BGP configmap #16412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christarazi
added
area/CI-improvement
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
|
test-only --focus="K8sServicesTest.*Connectivity to endpoint via LB" --k8s_version=1.21 --kernel_version=net-next Edit: Test failed as expected; once dependent PR is merged, then we'll re-run |
We recently had a regression (cilium#16340) that occurred when the user specified node-selectors in their BGP configmap. The node-selectors were not picked up due to the bug that was fixed in cilium#16341. This commit is to add regression testing for the BGP integration. Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
force-pushed
the
pr/christarazi/expand-bgp-test
branch
from
961d6f8
to
f20f04b
Compare
|
test-only --focus="K8sServicesTest.*Connectivity to endpoint via LB" --k8s_version=1.21 --kernel_version=net-next Edit: Test passed: https://jenkins.cilium.io/job/Cilium-PR-Tests-Kernel-Focus/225/ |
tklauser
approved these changes
Jun 9, 2021
christarazi
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently had a regression
(#16340) that occurred when the
user specified node-selectors in their BGP configmap. The node-selectors
were not picked up due to the bug that was fixed in
#16341.
This commit is to add regression testing for the BGP integration.
Depends on #16341