node: Add WireguardPubKey to ToCiliumNode #16420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandro
added
area/encryption
|
test-me-please |
aanm
requested changes
Jun 3, 2021
This ensures the WireGuard public key is preserved when coverting a nodeTypes.Node object to a CiliumNode CRD. This conversion is currently only used for attaching external workloads (which has no support for WireGuard at the moment), but it might be used for other reasons in the future, therefore we should ensure that it propagates all information correctly. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
force-pushed
the
pr/gandro/wireguard-in-tociliumnode
branch
from
3d0c39e
to
45e71d1
Compare
|
test-me-please Edit: GitHub Image builder wasn't triggered. Had to close/reopen the PR. |
aanm
approved these changes
Jun 7, 2021
|
test-me-please |
christarazi
approved these changes
Jun 7, 2021
gandro
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the WireGuard public key is preserved when converting a
nodeTypes.Nodeobject to aCiliumNodeCRD. This conversion is currentlyis only used for attaching external workloads (which has no support for
WireGuard at the moment anyways), but it might be used in other places in the
future, therefore we should ensure that it propagates all information
correctly.
I discovered this while validating WireGuard support in Clustermesh.
This PR does not fix any outstanding bugs.