Update test/packet instructions for running CI tests on dedicated instances #16423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
christarazi
commented
Jun 3, 2021
christarazi
commented
- test/packet: Update README.md
- test/packet: Update terraform script
- test/packet: Update provision installation script
christarazi
added
area/misc
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
christarazi
changed the title
christarazi
force-pushed
the
pr/christarazi/update-packet-instructions
branch
from
d782148
to
145c607
Compare
aanm
reviewed
Jun 3, 2021
test/packet/README.md
Outdated
| 1) Enter the `test` directory with `cd test` | ||
| 1) Run the ginkgo command to initialize the tests, for example: | ||
| `K8S_VERSION=1.14 ginkgo --focus="K8s" -v -- --cilium.showCommands --cilium.holdEnvironment=true` | ||
| 1) Once tests are running and if you are running `screen`, you can leave the terminal |
There was a problem hiding this comment.
I don't understand :). If you're referring to all the steps being marked as "1", that's supported by markdown and it will render properly. But I'll change it anyway so that we can refer to it easily.
christarazi
force-pushed
the
pr/christarazi/update-packet-instructions
branch
from
145c607
to
e67494e
Compare
This commit includes various updates:
- Rework the formatting so that it is renderable and readable in the
browser
- Add missing instructions to create a ssh key pair
- Clarify the terraform variables that need to be set
- Use terraform > 0.13 syntax (drop the `.` from `terraform init .`)
Signed-off-by: Chris Tarazi <chris@isovalent.com>
This commits makes various updates to the terraform script:
- Rename references from `packet` to `metal` as
https://github.com/packethost/terraform-provider-packet has been
deprecated in favor of
https://github.com/equinix/terraform-provider-metal
- Use the `metal` provider
(https://registry.terraform.io/providers/equinix/metal/latest)
- Add the ability to use / create an SSH key within metal / packet
- Introduce `public_key_path` for specifying the public key to
upload to metal / packet
- Depend on the SSH key for the provisioning steps
- Use Ubuntu 20.04 LTS by default
Signed-off-by: Chris Tarazi <chris@isovalent.com>
This commit contains various updates to the script:
- Drop VIRTUALBOX_VERSION as it is no longer needed because 6.0 is now
the default version on the recent Ubuntu releases (after bionic)
- Update the VAGRANT_VERSION to a more modern version
- Install NFS client and server for better compatibility with our
e2e suite
Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
force-pushed
the
pr/christarazi/update-packet-instructions
branch
from
e67494e
to
9f704ae
Compare
aanm
approved these changes
Jun 4, 2021
nebril
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.