Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go to 1.16.5 #16428

Merged
merged 1 commit into from Jun 9, 2021
Merged

Update Go to 1.16.5 #16428

merged 1 commit into from Jun 9, 2021

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Jun 4, 2021

No description provided.

@tklauser tklauser added the release-note/misc This PR makes changes that have no direct user impact. label Jun 4, 2021
@tklauser tklauser temporarily deployed to release-base-images June 4, 2021 07:51 Inactive
@tklauser tklauser temporarily deployed to release-base-images June 4, 2021 07:51 Inactive
@tklauser tklauser temporarily deployed to release-base-images June 4, 2021 07:58 Inactive
@tklauser tklauser temporarily deployed to release-base-images June 4, 2021 07:58 Inactive
@tklauser tklauser temporarily deployed to release-base-images June 4, 2021 08:07 Inactive
@tklauser tklauser temporarily deployed to release-base-images June 4, 2021 08:07 Inactive
@tklauser tklauser marked this pull request as ready for review June 4, 2021 08:07
@tklauser tklauser requested review from a team as code owners June 4, 2021 08:07
@tklauser tklauser requested a review from jrajahalme June 4, 2021 08:07
@tklauser
Copy link
Member Author

tklauser commented Jun 4, 2021

test-me-please

@tklauser
Copy link
Member Author

tklauser commented Jun 4, 2021 •
edited

test-runtime

previous: https://jenkins.cilium.io/job/Cilium-PR-Runtime-4.9/4879 (VM provisioning failure)

christarazi
christarazi approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A rebase is needed

@christarazi christarazi added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Jun 4, 2021
@tklauser
Update Go to 1.16.5
bf3275b 
Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Jun 4, 2021
@tklauser
Copy link
Member Author

tklauser commented Jun 4, 2021

test-me-please

@tklauser
Copy link
Member Author

tklauser commented Jun 7, 2021 •
edited

test-1.21-4.9

previous: looks like #16409 https://jenkins.cilium.io/job/Cilium-PR-K8s-1.21-kernel-4.9/630/

@tklauser
Copy link
Member Author

tklauser commented Jun 7, 2021 •
edited

test-1.21-4.9

previous: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.21-kernel-4.9/651

@tklauser
Copy link
Member Author

tklauser commented Jun 9, 2021

Received enough reviews and all required tests passed. Marking as ready to merge.

@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 9, 2021
@tklauser
Copy link
Member Author

tklauser commented Jun 9, 2021

k8s-1.21-kernel-4.9 CI job was for some reason triggered by mistake by my previous comment and failed due to the comment not matching the trigger phrase: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.21-kernel-4.9/676/.

That job previously passed on this PR, see https://jenkins.cilium.io/job/Cilium-PR-K8s-1.21-kernel-4.9/657/ so this PR is still ready to be merged.

@aanm aanm merged commit ad69944 into master Jun 9, 2021
@aanm aanm deleted the pr/tklauser/go-1.16.5 branch June 9, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@christarazi christarazi christarazi approved these changes

@aanm aanm aanm approved these changes

@michi-covalent michi-covalent michi-covalent approved these changes

@jrajahalme jrajahalme Awaiting requested review from jrajahalme

Assignees

@jrajahalme jrajahalme

Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tklauser @pchaigno @christarazi @aanm @michi-covalent @jrajahalme