Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/helpers: Save JSON artifacts as .json #16442

Merged
merged 1 commit into from Jun 7, 2021

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Jun 4, 2021

Some JSON test artifacts had a .txt file extension which messes up syntax highlighting in editors and give the wrong indication as to the content of the file.

Some JSON test artifacts had a .txt file extension which messes up
syntax highlighting in editors and give the wrong indication as to the
content of the file.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Jun 4, 2021
@pchaigno pchaigno requested a review from a team as a code owner June 4, 2021 20:02
@pchaigno pchaigno requested a review from nebril June 4, 2021 20:02
@christarazi christarazi removed the request for review from nebril June 4, 2021 23:19
@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 5, 2021
@aanm aanm merged commit e2b62ef into cilium:master Jun 7, 2021
@pchaigno pchaigno deleted the save-artifacts-as-json branch June 7, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants