Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix build failure #16454

Merged
merged 1 commit into from Jun 7, 2021
Merged

docs: Fix build failure #16454

merged 1 commit into from Jun 7, 2021

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Jun 7, 2021 •
edited

By error, commit d5f0cd5 ("Deprecate SkipCRDCreation option for cilium-agents") was merged when the documentation build was failing. This commit fixes it.

Fixes: #15655.
/cc @errordeveloper @aanm

@pchaigno
docs: Fix build failure
9e683eb 
By error, commit d5f0cd5 ("Deprecate SkipCRDCreation option for
cilium-agents") was merged when the documentation build was failing.
This commit fixes it.

Fixes: d5f0cd5 ("Deprecate SkipCRDCreation option for cilium-agents")
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added kind/bug This is a bug in the Cilium logic. release-note/misc This PR makes changes that have no direct user impact. labels Jun 7, 2021
@aanm aanm merged commit b173979 into cilium:master Jun 7, 2021
@pchaigno pchaigno requested a review from aanm June 7, 2021 13:15
@pchaigno pchaigno added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Jun 7, 2021
@pchaigno pchaigno deleted the fix-docs-build branch June 7, 2021 13:18
aanm
aanm reviewed Jun 7, 2021
View reviewed changes
Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aanm aanm removed their assignment Jun 7, 2021
@pchaigno pchaigno mentioned this pull request Jun 14, 2021
Merged
@pchaigno
Copy link
Member Author

Added backport label for v1.10 since the PR that introduced the issue was also marked for backport.

@aanm aanm mentioned this pull request Jun 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm left review comments

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/bug This is a bug in the Cilium logic. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pchaigno @aanm @gandro