bpf: rename variables with camel-case names #16476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmonnet
added
sig/datapath
|
test-me-please |
|
test-1.21-4.9 |
qmonnet
force-pushed
the
pr/bpf-camel-case
branch
2 times, most recently
from
a738f5d
to
21122fa
Compare
|
test-me-please |
pchaigno
approved these changes
Jun 17, 2021
pchaigno
added
the
needs/triage
|
The Jenkins builds expired, so I retriggered: test-me-please |
qmonnet
force-pushed
the
pr/bpf-camel-case
branch
from
21122fa
to
3063dd5
Compare
|
test-me-please |
We run checkpatch.pl on the commits touching the bpf/ code, and it complains when edits contain camel-case variable names -- even if they were not introduced by the commit. We could disable this report in the script we use to call checkpatch.pl, but at the same time we _do_ want it to catch the introduction of new camel-case names. Let's fix the existing variable names once and for all, to avoid contributors to get surprised by the reports. The number of variables is rather low: srcID, dstID, localID, remoteID, and newEntries. Signed-off-by: Quentin Monnet <quentin@isovalent.com>
qmonnet
force-pushed
the
pr/bpf-camel-case
branch
from
3063dd5
to
d5a5b44
Compare
|
Rebased because the PR has been left aside for some time. |
jrfastab
approved these changes
Jul 15, 2021
qmonnet
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run checkpatch.pl on the commits touching the bpf/ code, and it complains when edits contain camel-case variable names -- even if they were not introduced by the commit. We could disable this report in the script we use to call checkpatch.pl, but at the same time we do want it to catch the introduction of new camel-case names.
As suggested in #16447 (comment), let's fix the existing variable names once and for all, to avoid contributors to get surprised by the reports.
The number of variables is rather low:
srcID,dstID,localID,remoteID, andnewEntries.