Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodePort health checks should be disabled when kube-proxy is installed #16477

Merged
merged 2 commits into from
Jun 10, 2021
Merged

NodePort health checks should be disabled when kube-proxy is installed #16477

merged 2 commits into from
Jun 10, 2021

Commits on Jun 8, 2021

  1. healthserver: Clarify when NodePort health checks should be disabled 

    The first part of the message says the error happens when running with
kube-proxy, but the second part only recommends to disable health checks
if running with KPR=partial. My own tests also show this error can
happen when KPR=strict and kube-proxy is installed.

Signed-off-by: Paul Chaignon <paul@cilium.io>
    @pchaigno
    pchaigno committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    d107ffb View commit details
    Browse the repository at this point in the history

  2. test/helpers: Disable NodePort health checks if using kube-proxy 

    In the 4.19 CI job, we run with KPR=strict for most tests even though
kube-proxy is installed. As a result, we get an error message because
the agent fails to listen on the health checks port. In that setup, we
should instead disable health checks.

Signed-off-by: Paul Chaignon <paul@cilium.io>
    @pchaigno
    pchaigno committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    be6b21e View commit details
    Browse the repository at this point in the history