workflows: Skip jobs instead of workflows #16487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
area/CI
aanm
approved these changes
Jun 9, 2021
pchaigno
force-pushed
the
docs-skip-job-instead-of-workflow
branch
2 times, most recently
from
6cc6990
to
42c2247
Compare
In its initial version, commit 3ceb742 (".github: Skip unnecessary docs test") skipped the job instead of the whole workflow, based on changed code paths. After discussion on the pull request [1], we figured we could save some seconds by skipping the whole workflow instead of the job. Skipping the job requires adding a new job to check the code paths. However, if we skip the whole workflow, the job status is never reported on GitHub. Since the documentation job is required to merge, that means maintainer's little helper will never mark the pull request as ready to merge. Thus, this commit reverts back to skipping the jobs instead of the whole workflows. To that end, we use paths-filter GitHub Action instead of the direct GitHub integration (since the GitHub path filters can only skip the whole workflow). 1 - cilium#16157 (comment) Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
docs-skip-job-instead-of-workflow
branch
from
42c2247
to
d17a2b8
Compare
pchaigno
changed the title
tklauser
approved these changes
Jun 10, 2021
pchaigno
added
the
ready-to-merge
aanm
approved these changes
Jun 10, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In its initial version, commit 3ceb742 (".github: Skip unnecessary docs test") skipped the job instead of the whole workflow, based on changed code paths. After discussion on the pull request, we figured we could save some seconds by skipping the whole workflow instead of the job. Skipping the job requires adding a new job to check the code paths.
However, if we skip the whole workflow, the job status is never reported on GitHub. Since the documentation job is required to merge, that means maintainer's little helper will never mark the pull request as ready to merge.
Thus, this pull request reverts back to skipping the jobs instead of the whole workflows. To that end, we use
paths-filterGitHub Action instead of the direct GitHub integration (since the GitHub path filters can only skip the whole workflow).