Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix artifact collection for bad log failures #16489

Merged
merged 1 commit into from
Jun 11, 2021
Merged

test: Fix artifact collection for bad log failures #16489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/test_suite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ var _ = AfterEach(func() {
}

// This piece of code is to enable zip attachments on Junit Output.
if ginkgo.CurrentGinkgoTestDescription().Failed && helpers.IsRunningOnJenkins() {
if TestFailed() && helpers.IsRunningOnJenkins() {
// ReportDirectory is already created. No check the error
path, _ := helpers.CreateReportDirectory()
zipFileName := fmt.Sprintf("%s_%s.zip", helpers.MakeUID(), GetTestName())
Expand All @@ -331,7 +331,7 @@ var _ = AfterEach(func() {
GinkgoPrint("[[ATTACHMENT|%s]]", zipFileName)
}

if !ginkgo.CurrentGinkgoTestDescription().Failed && helpers.IsRunningOnJenkins() {
if !TestFailed() && helpers.IsRunningOnJenkins() {
// If the test success delete the monitor.log filename to not store all
// the data in Jenkins
testPath, err := helpers.CreateReportDirectory()
Expand Down