workflows: Skip building cilium-operator image #16501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
area/CI-improvement
pchaigno
force-pushed
the
pr/pchaigno/skip-building-cilium-operator-image
branch
8 times, most recently
from
6029a30
to
9ee4d8a
Compare
nbusseneau
approved these changes
Jun 14, 2021
christarazi
approved these changes
Jun 14, 2021
|
So now do we expect users to build their own Operator variant if they want to use the latest? |
If they want to use the multi-IPAM image, yes. But they can also use |
We don't need the cilium-operator image in CI, only the cilium-operator-xxx variants. We therefore don't need to build that image for every pushes and pull requests. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
pr/pchaigno/skip-building-cilium-operator-image
branch
2 times, most recently
from
ca5e48f
to
4f02ff2
Compare
pchaigno
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this PR by switching from
pull_request_targettopull_requestand all tests were passing except for ConformanceAKS and ConformanceEKS. These two were failing with known flakes on flow validation, unrelated to the cilium-operator image.