workflows: Fix use of paths-filter on master pushes #16507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For pull requests, paths-filter retrieves the list of changed files via
the GitHub API, but for pushes it needs access to the code. When a
workflow is triggered by a push to master, we therefore need to checkout
the source code before using paths-filter.
This change fixes the errors:
Run dorny/paths-filter@78ab00f
Get current git ref
/usr/bin/git branch --show-current
fatal: not a git repository (or any of the parent directories): .git
Error: The process '/usr/bin/git' failed with exit code 128
Reported-by: André Martins <andre@cilium.io>
Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
kind/bug/CI
aanm
approved these changes
Jun 11, 2021
|
Added needs-backport/1.10 as the v1.10 branch build is hitting the same issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For pull requests, paths-filter retrieves the list of changed files via the GitHub API, but for pushes it needs access to the code. When a workflow is triggered by a push to master, we therefore need to checkout the source code before using paths-filter.
This change fixes the errors:
I tested it by pushing to my fork's default branch. The result can be seen at: https://github.com/pchaigno/cilium/runs/2801208965?check_suite_focus=true.
Reported-by: André Martins andre@cilium.io