fix: conditionally change hubble-relay port in hubble-ui #16511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of enabled TLS for Hubble Relay the hubble-ui shall follow the service port change Fixes #16510 Signed-off-by: Alex Szakaly <alex.szakaly@gmail.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
alex1989hu
changed the title
gandro
added
release-note/misc
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
gandro
reviewed
Jun 14, 2021
rolinh
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
What @gandro mentioned is indeed valid and something to keep in mind. However, as of now, users enabling TLS for Hubble Relay will already notice that the Hubble UI will stop working when doing so. With this change however, the error might be more clear as the connection should fail with a TLS error instead of timing out. TLDR: I think this is OK to merge even though Hubble UI does not yet support TLS.
gandro
approved these changes
Jun 14, 2021
kaworu
approved these changes
Jun 15, 2021
nebril
approved these changes
Jun 21, 2021
|
Given that Hubble UI is not deployed anywhere in our CI, a full CI run is unnecessary. As this PR got all required approvals from the various teams, marking as ready to merge. |
rolinh
added
the
ready-to-merge
sayboras
approved these changes
Jun 21, 2021
alex1989hu
deleted the
fix/conditionally-change-hubble-relay-port-in-hubble-ui
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of enabled TLS for Hubble Relay the hubble-ui
shall follow the service port change
Signed-off-by: Alex Szakaly alex.szakaly@gmail.com
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: #16510