Extend cilium config to expose all active configurations. Add subcommand cilium config get to get configurations from CLI
#16519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
maintainer-s-little-helper
bot
added
dont-merge/needs-sign-off
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
aanm
reviewed
Jun 15, 2021
|
Yes @aanm . All fields need to be public. Though there is a way we can read unexported fileds by using reflect's unsafe pointer. |
pchaigno
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
pchaigno
reviewed
Jun 21, 2021
h3llix
commented
Jul 13, 2021
h3llix
force-pushed
the
hellixSoc
branch
3 times, most recently
from
ce142a5
to
aa6f8bb
Compare
h3llix
changed the title
cilium config to expose all active configuraitons. Add subcommand cilium config get to get configurations from CLI
h3llix
force-pushed
the
hellixSoc
branch
2 times, most recently
from
b2035f6
to
63ca380
Compare
christarazi
reviewed
Aug 16, 2021
h3llix
force-pushed
the
hellixSoc
branch
2 times, most recently
from
3842db4
to
3615599
Compare
christarazi
reviewed
Aug 23, 2021
christarazi
approved these changes
Aug 24, 2021
nathanjsweet
approved these changes
Aug 30, 2021
pchaigno
reviewed
Aug 31, 2021
Note: All the daemon configurations have to be public for reflections to work Signed-off-by: Gaurav Genani <h3llix.pvt@gmail.com>
cilium config get <config_name> gives configuration value from the cli. conifg_name should be in kebab case. Signed-off-by: Gaurav Genani <h3llix.pvt@gmail.com>
pchaigno
approved these changes
Aug 31, 2021
rolinh
approved these changes
Aug 31, 2021
Add -r flag to show read-only configurations while default cilium config show read-write configurations Signed-off-by: Gaurav Genani <h3llix.pvt@gmail.com>
|
test-me-please Job 'Cilium-PR-K8s-1.16-net-next' hit: #17060 (84.67% similarity) |
|
All tests are passing except for the one known flake above. All reviews are in except for Joe's but he said before that he was okay to merge without waiting for his review. I'm marking ready to merge. |
pchaigno
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13913
For
cilium config get <config_name>configuration name should be in kebab case. For exampleEncryptNode, So we can get its value bycilium config get encrypt-node. Add flag -r to display read-only configurations.Test-image :
docker.io/h3llix/cilium-dev:cilium-config(if required)