Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Tiny cleanup of k8s_install.sh #16534

Merged
merged 2 commits into from
Jun 15, 2021
Merged

test: Tiny cleanup of k8s_install.sh #16534

merged 2 commits into from
Jun 15, 2021

Conversation

brb
Copy link
Member

@brb brb commented Jun 15, 2021

See commit msgs.

brb added 2 commits June 15, 2021 10:14
@brb
test: Do not create Docker network in k8s provision
ec59fc2 
The network was used to send requests from outside which has been
replaced by the k8s3 node. The node doesn't run Cilium, so it can be
used to run tests from "outside".

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb
test: More neutral terminology in k8s_install.sh
67547dd 
Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb added area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. labels Jun 15, 2021
@brb brb requested a review from a team as a code owner June 15, 2021 08:20
@brb brb requested a review from tklauser June 15, 2021 08:20
@brb
Copy link
Member Author

brb commented Jun 15, 2021

test-me-please

tklauser
tklauser approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 15, 2021
@aditighag aditighag merged commit b4147df into master Jun 15, 2021
@aditighag aditighag deleted the pr/brb/cleanup-test-k8s-install branch June 15, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

Assignees
No one assigned
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brb @tklauser @aditighag