Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

images/script: update the example hubble cli Deployment version #16537

Merged
merged 2 commits into from
Jun 15, 2021
Merged

images/script: update the example hubble cli Deployment version #16537

merged 2 commits into from
Jun 15, 2021

Conversation

kaworu
Copy link
Member

@kaworu kaworu commented Jun 15, 2021

Update the Hubble CLI image version in the Deployment examples/ whenever we bump the Hubble CLI inside Cilium.

See #16459 (comment) for context.

@kaworu kaworu added kind/enhancement This would improve or streamline existing functionality. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay needs-backport/1.10 labels Jun 15, 2021
@kaworu kaworu requested review from gandro and rolinh June 15, 2021 10:17
@kaworu kaworu requested a review from a team as a code owner June 15, 2021 10:17
@kaworu kaworu self-assigned this Jun 15, 2021
@kaworu kaworu mentioned this pull request Jun 15, 2021
Merged
@kaworu kaworu requested a review from a team as a code owner June 15, 2021 10:40
@kaworu kaworu requested a review from qmonnet June 15, 2021 10:40
@kaworu kaworu mentioned this pull request Jun 15, 2021
Merged
gandro
gandro approved these changes Jun 15, 2021
View reviewed changes
images/scripts/update-hubble-version.sh Outdated Show resolved Hide resolved
@kaworu kaworu force-pushed the pr/kaworu/update-example-hubble-cli-in-update-hubble-version branch from 93ac6e0 to 43e7446 Compare June 15, 2021 14:15
@kaworu
images/script: update the example hubble cli Deployment version
abe4aa9 
Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
@kaworu
examples: pull the hubble cli image only IfNotPresent
43e7446 
Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
@kaworu
Copy link
Member Author

kaworu commented Jun 15, 2021

Note to @cilium/janitors: no need to run CI on this PR.

@kaworu kaworu added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 15, 2021
@aditighag aditighag merged commit 69b2faf into cilium:master Jun 15, 2021
@nathanjsweet nathanjsweet mentioned this pull request Jun 16, 2021
Merged
4 tasks
@kaworu kaworu deleted the pr/kaworu/update-example-hubble-cli-in-update-hubble-version branch June 17, 2021 09:42
@aanm aanm mentioned this pull request Jul 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolinh rolinh rolinh approved these changes

@qmonnet qmonnet qmonnet approved these changes

@gandro gandro gandro approved these changes

Assignees

@kaworu kaworu

Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@kaworu @gandro @rolinh @qmonnet @nathanjsweet @christarazi @aditighag