Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cicd: skip codesql on forks #16560

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Conversation

ldelossa
Copy link
Contributor

introduces an if statement into the codesql lint action
which skips the work if its taking place on a fork.

Signed-off-by: ldelossa louis.delos@isovalent.com

@ldelossa ldelossa requested review from a team as code owners June 16, 2021 14:01
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 16, 2021
@ldelossa ldelossa requested review from nebril and pchaigno June 16, 2021 14:01
@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Jun 16, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 16, 2021
@aanm
Copy link
Member

aanm commented Jun 16, 2021

Likely needs some backport labels to older branches? 🤔

@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. and removed release-note/misc This PR makes changes that have no direct user impact. labels Jun 16, 2021
.github/workflows/lint-codeql.yaml Outdated Show resolved Hide resolved
introduces an if statement into the codesql lint action
which skips the work if its taking place on a fork.

Signed-off-by: ldelossa <louis.delos@isovalent.com>
@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 16, 2021
@nebril nebril merged commit a38470c into cilium:master Jun 17, 2021
@tklauser
Copy link
Member

Likely needs some backport labels to older branches? thinking

Yup. Just hit a failure in the codeql job on v1.10 backport #16686. I'll mark this for backport and pick it up into that PR. It seems we didn't have the codeql job before v1.10, so no need to backport to 1.9 or earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants