-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cicd: skip codesql on forks #16560
Merged
Merged
cicd: skip codesql on forks #16560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
approved these changes
Jun 16, 2021
Likely needs some backport labels to older branches? 🤔 |
pchaigno
requested changes
Jun 16, 2021
introduces an if statement into the codesql lint action which skips the work if its taking place on a fork. Signed-off-by: ldelossa <louis.delos@isovalent.com>
3dcdeee
to
caa9d33
Compare
pchaigno
approved these changes
Jun 16, 2021
nebril
approved these changes
Jun 17, 2021
Yup. Just hit a failure in the codeql job on v1.10 backport #16686. I'll mark this for backport and pick it up into that PR. It seems we didn't have the codeql job before v1.10, so no need to backport to 1.9 or earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/CI
Continuous Integration testing issue or flake
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/ci
This PR makes changes to the CI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduces an if statement into the codesql lint action
which skips the work if its taking place on a fork.
Signed-off-by: ldelossa louis.delos@isovalent.com