Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.10 backports 2021-06-16 #16562

Merged
merged 5 commits into from Jun 22, 2021
Merged

v1.10 backports 2021-06-16 #16562

merged 5 commits into from Jun 22, 2021

Commits on Jun 16, 2021

  1. CODEOWNERS: Give maintainer's code to github-sec team 

    [ upstream commit 2fe7c50 ]

The new github-sec team will include more contributors than just the
maintainers, to help scale reviews.

Signed-off-by: Paul Chaignon <paul@cilium.io>
Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
    @pchaigno @nathanjsweet
    pchaigno authored and nathanjsweet committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    e1e8c7b View commit details
    Browse the repository at this point in the history

  2. workflows: Skip jobs instead of workflows 

    [ upstream commit b08f700 ]

In its initial version, commit 3ceb742 (".github: Skip unnecessary docs
test") skipped the job instead of the whole workflow, based on changed
code paths. After discussion on the pull request [1], we figured we
could save some seconds by skipping the whole workflow instead of the
job. Skipping the job requires adding a new job to check the code paths.

However, if we skip the whole workflow, the job status is never reported
on GitHub. Since the documentation job is required to merge, that means
maintainer's little helper will never mark the pull request as ready to
merge.

Thus, this commit reverts back to skipping the jobs instead of the whole
workflows. To that end, we use paths-filter GitHub Action instead of the
direct GitHub integration (since the GitHub path filters can only skip
the whole workflow).

1 - #16157 (comment)
Signed-off-by: Paul Chaignon <paul@cilium.io>
Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
    @pchaigno @nathanjsweet
    pchaigno authored and nathanjsweet committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    67b2f9a View commit details
    Browse the repository at this point in the history

  3. docs: Hubble UI does not show L7 endpoints anymore 

    [ upstream commit fea1b27 ]

This removes a note in the Hubble getting started guide that recommends
turning on L7 visibility to see what L7 endpoints are being used by
flows. This feature has been removed in Hubble UI 0.7 (Cilium
1.9), making the note obsolete.

Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
    @gandro @nathanjsweet
    gandro authored and nathanjsweet committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    dec9047 View commit details
    Browse the repository at this point in the history

  4. images/script: update the example hubble cli Deployment version 

    [ upstream commit 850aaab ]

Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
    @kaworu @nathanjsweet
    kaworu authored and nathanjsweet committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    a191fb8 View commit details
    Browse the repository at this point in the history

  5. examples: pull the hubble cli image only IfNotPresent 

    [ upstream commit 69b2faf ]

Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
    @kaworu @nathanjsweet
    kaworu authored and nathanjsweet committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    b289b4e View commit details
    Browse the repository at this point in the history