helm: Allow configuration of probe timers #16584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
assigned kaworu and errordeveloper and unassigned errordeveloper
aanm
reviewed
Jun 17, 2021
jonkerj
force-pushed
the
configurable-probe-parameters
branch
from
10236b8
to
6cfa3a3
Compare
kaworu
approved these changes
Jun 18, 2021
kaworu
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
aanm
approved these changes
Jun 18, 2021
|
marking for backport since this is currently broken in environments running k8s >= 1.21 |
jonkerj
force-pushed
the
configurable-probe-parameters
branch
from
6cfa3a3
to
0593a2e
Compare
|
Fixed the docs, should be good now |
|
Anything else I can (or need to) do? |
errordeveloper
approved these changes
Jun 23, 2021
|
test-me-please |
1 similar comment
|
test-me-please |
|
@jonkerj no, I think everything will work as fine. Thanks for the PR! |
|
Commit 289bd54719221654ace4be1eb8ad9fc6d77895f9 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
This commit makes the period and threshold of the startup, readiness and liveness probe configurable. It also makes the tolerance of the startupProbe roughly equivalent to the initialDelay construction. Signed-off-by: Jorik Jonker <jorik@kippendief.biz>
jonkerj
force-pushed
the
configurable-probe-parameters
branch
from
289bd54
to
84edffb
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
|
rebased, fixed conflicts. Quick, merge! 🤣 |
aanm
approved these changes
Jun 28, 2021
|
test-me-please |
|
I don't think the failing tests are due to my changes, but please let me know if you expect something from me (this is my first Cilium PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the period and threshold of the startup, readiness and liveness probe configurable. It also makes the tolerance of the
startupProberoughly equivalent to theinitialDelayconstruction.description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.