pkg/identity: Add missing labels to well-known identities #16585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
aanm
requested changes
Jun 17, 2021
aanm
added
needs-backport/1.10
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
mauriciovasquezbernal
force-pushed
the
mauricio/add-missing-label-well-known-identities
branch
2 times, most recently
from
6324f2f
to
717d35c
Compare
8 tasks
jrajahalme
reviewed
Jun 22, 2021
aanm
approved these changes
Jun 22, 2021
brb
reviewed
Jul 13, 2021
|
test-me-please |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
stale
|
@mauriciovasquezbernal can you rebase the PR so that we can re-run the tests again? Thank you |
stale
bot
removed
the
stale
Kubernetes 1.21 automatically adds a new label to all namespaces when the NamespaceDefaultLabelName feature gate is enabled. (https://kubernetes.io/docs/concepts/overview/_print/#automatic-labelling) This commit adds an additional entry for all well-known identities adding that label. Signed-off-by: Mauricio Vásquez <mauricio@accuknox.com> Signed-off-by: Mauricio Vásquez <mauricio@kinvolk.io>
mauriciovasquezbernal
force-pushed
the
mauricio/add-missing-label-well-known-identities
branch
from
717d35c
to
c0c91d3
Compare
|
@aanm done. |
|
test-me-please Job 'Cilium-PR-K8s-1.16-net-next' failed and has not been observed before, so may be related to your PR: Click to show.Test NameFailure OutputIf it is a flake, comment |
|
although some tests have failed they are likely flakes since for other kubernetes versions they have not failed. |
mauriciovasquezbernal
deleted the
mauricio/add-missing-label-well-known-identities
branch
This was referenced Sep 27, 2021
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport done to v1.10
in 1.10.5
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes 1.21 automatically adds a new label to all namespaces when
the NamespaceDefaultLabelName feature gate is enabled.
(https://kubernetes.io/docs/concepts/overview/_print/#automatic-labelling)
This commit adds an additional entry for all well-known identities
adding that label.